Ignore:
Timestamp:
Apr 20, 2010, 12:28:41 PM (15 years ago)
Author:
[email protected]
Message:

Bug 37828 - Move WebCore's String classes to WTF

Reviewed by Geoff Garen.

Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).

As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").

JavaScriptCore:

Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
  • wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
  • wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
  • wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
  • wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
  • wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
  • wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
  • wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
  • wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.

(WebCore::charactersToFloat):

  • wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.

WebCore:

Moving the files, but leaving the classes logically in the WebCore namespace –
which is technically a layering violation – I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • ForwardingHeaders/wtf/StaticConstructors.h: Added.
  • ForwardingHeaders/wtf/text/AtomicString.h: Added.
  • ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
  • ForwardingHeaders/wtf/text/StringBuffer.h: Added.
  • ForwardingHeaders/wtf/text/StringHash.h: Added.
  • ForwardingHeaders/wtf/text/StringImpl.h: Added.
  • ForwardingHeaders/wtf/text/WTFString.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/MediaFeatureNames.cpp:
  • dom/QualifiedName.cpp:
  • dom/make_names.pl:
  • platform/StaticConstructors.h: Removed.
  • platform/text/AtomicString.cpp: Removed.
  • platform/text/AtomicString.h:
  • platform/text/AtomicStringImpl.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringHash.h:
  • platform/text/StringImpl.cpp: Removed.
  • platform/text/StringImpl.h:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r57879 r57904  
    199199                86565743115BE3DA00291F40 /* CString.h in Headers */ = {isa = PBXBuildFile; fileRef = 86565741115BE3DA00291F40 /* CString.h */; settings = {ATTRIBUTES = (Private, ); }; };
    200200                865F408810E7D56300947361 /* APIShims.h in Headers */ = {isa = PBXBuildFile; fileRef = 865F408710E7D56300947361 /* APIShims.h */; };
     201                868BFA08117CEFD100B908B1 /* AtomicString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 868BFA00117CEFD100B908B1 /* AtomicString.cpp */; };
     202                868BFA09117CEFD100B908B1 /* AtomicString.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA01117CEFD100B908B1 /* AtomicString.h */; settings = {ATTRIBUTES = (Private, ); }; };
     203                868BFA0A117CEFD100B908B1 /* AtomicStringImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA02117CEFD100B908B1 /* AtomicStringImpl.h */; settings = {ATTRIBUTES = (Private, ); }; };
     204                868BFA0D117CEFD100B908B1 /* StringHash.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA05117CEFD100B908B1 /* StringHash.h */; settings = {ATTRIBUTES = (Private, ); }; };
     205                868BFA0E117CEFD100B908B1 /* StringImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 868BFA06117CEFD100B908B1 /* StringImpl.cpp */; };
     206                868BFA0F117CEFD100B908B1 /* StringImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA07117CEFD100B908B1 /* StringImpl.h */; settings = {ATTRIBUTES = (Private, ); }; };
     207                868BFA17117CF19900B908B1 /* WTFString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 868BFA15117CF19900B908B1 /* WTFString.cpp */; };
     208                868BFA18117CF19900B908B1 /* WTFString.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA16117CF19900B908B1 /* WTFString.h */; settings = {ATTRIBUTES = (Private, ); }; };
     209                868BFA60117D048200B908B1 /* StaticConstructors.h in Headers */ = {isa = PBXBuildFile; fileRef = 868BFA5F117D048200B908B1 /* StaticConstructors.h */; settings = {ATTRIBUTES = (Private, ); }; };
    201210                8698B86910D44D9400D8D01B /* StringBuilder.h in Headers */ = {isa = PBXBuildFile; fileRef = 8698B86810D44D9400D8D01B /* StringBuilder.h */; settings = {ATTRIBUTES = (Private, ); }; };
    202211                8698BB3910D86BAF00D8D01B /* UStringImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 8698BB3710D86BAF00D8D01B /* UStringImpl.h */; settings = {ATTRIBUTES = (Private, ); }; };
     
    561570                088FA5BA0EF76D4300578E6F /* RandomNumber.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RandomNumber.h; sourceTree = "<group>"; };
    562571                08E279E80EF83B10007DB523 /* RandomNumberSeed.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RandomNumberSeed.h; sourceTree = "<group>"; };
    563                 0B1F921B0F17502D0036468E /* PtrAndFlags.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PtrAndFlags.h; sourceTree = "<group>"; };
    564572                0B330C260F38C62300692DE3 /* TypeTraits.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TypeTraits.cpp; sourceTree = "<group>"; };
    565573                0B4D7E620F319AC800AD7E58 /* TypeTraits.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TypeTraits.h; sourceTree = "<group>"; };
     
    730738                86565741115BE3DA00291F40 /* CString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CString.h; path = text/CString.h; sourceTree = "<group>"; };
    731739                865F408710E7D56300947361 /* APIShims.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIShims.h; sourceTree = "<group>"; };
     740                868BFA00117CEFD100B908B1 /* AtomicString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = AtomicString.cpp; path = text/AtomicString.cpp; sourceTree = "<group>"; };
     741                868BFA01117CEFD100B908B1 /* AtomicString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AtomicString.h; path = text/AtomicString.h; sourceTree = "<group>"; };
     742                868BFA02117CEFD100B908B1 /* AtomicStringImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AtomicStringImpl.h; path = text/AtomicStringImpl.h; sourceTree = "<group>"; };
     743                868BFA05117CEFD100B908B1 /* StringHash.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = StringHash.h; path = text/StringHash.h; sourceTree = "<group>"; };
     744                868BFA06117CEFD100B908B1 /* StringImpl.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = StringImpl.cpp; path = text/StringImpl.cpp; sourceTree = "<group>"; };
     745                868BFA07117CEFD100B908B1 /* StringImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = StringImpl.h; path = text/StringImpl.h; sourceTree = "<group>"; };
     746                868BFA15117CF19900B908B1 /* WTFString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = WTFString.cpp; path = text/WTFString.cpp; sourceTree = "<group>"; };
     747                868BFA16117CF19900B908B1 /* WTFString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WTFString.h; path = text/WTFString.h; sourceTree = "<group>"; };
     748                868BFA5F117D048200B908B1 /* StaticConstructors.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StaticConstructors.h; sourceTree = "<group>"; };
    732749                8698B86810D44D9400D8D01B /* StringBuilder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringBuilder.h; sourceTree = "<group>"; };
    733750                8698BB3710D86BAF00D8D01B /* UStringImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UStringImpl.h; sourceTree = "<group>"; };
     
    13571374                                65D6D87E09B5A32E0002E4D7 /* Platform.h */,
    13581375                                A7D649A91015224E009B2E1B /* PossiblyNull.h */,
    1359                                 0B1F921B0F17502D0036468E /* PtrAndFlags.h */,
    13601376                                088FA5B90EF76D4300578E6F /* RandomNumber.cpp */,
    13611377                                088FA5BA0EF76D4300578E6F /* RandomNumber.h */,
     
    13681384                                51F648D60BB4E2CA0033D760 /* RetainPtr.h */,
    13691385                                969A07290ED1CE6900F1F681 /* SegmentedVector.h */,
     1386                                868BFA5F117D048200B908B1 /* StaticConstructors.h */,
    13701387                                FE1B44790ECCD73B004F4DD1 /* StdLibExtras.h */,
    13711388                                E11D51750B2E798D0056C188 /* StringExtras.h */,
     
    16461663                        isa = PBXGroup;
    16471664                        children = (
     1665                                868BFA00117CEFD100B908B1 /* AtomicString.cpp */,
     1666                                868BFA01117CEFD100B908B1 /* AtomicString.h */,
     1667                                868BFA02117CEFD100B908B1 /* AtomicStringImpl.h */,
    16481668                                86565740115BE3DA00291F40 /* CString.cpp */,
    16491669                                86565741115BE3DA00291F40 /* CString.h */,
     1670                                868BFA05117CEFD100B908B1 /* StringHash.h */,
     1671                                868BFA06117CEFD100B908B1 /* StringImpl.cpp */,
     1672                                868BFA07117CEFD100B908B1 /* StringImpl.h */,
     1673                                868BFA15117CF19900B908B1 /* WTFString.cpp */,
     1674                                868BFA16117CF19900B908B1 /* WTFString.h */,
    16501675                        );
    16511676                        name = text;
     
    20432068                                A7482E93116A7CAD003B0712 /* JSWeakObjectMapRefInternal.h in Headers */,
    20442069                                86D08D5411793613006E5ED0 /* WTFThreadData.h in Headers */,
     2070                                868BFA09117CEFD100B908B1 /* AtomicString.h in Headers */,
     2071                                868BFA0A117CEFD100B908B1 /* AtomicStringImpl.h in Headers */,
     2072                                868BFA0D117CEFD100B908B1 /* StringHash.h in Headers */,
     2073                                868BFA0F117CEFD100B908B1 /* StringImpl.h in Headers */,
     2074                                868BFA18117CF19900B908B1 /* WTFString.h in Headers */,
     2075                                868BFA60117D048200B908B1 /* StaticConstructors.h in Headers */,
    20452076                        );
    20462077                        runOnlyForDeploymentPostprocessing = 0;
     
    24872518                                A7482B9411671147003B0712 /* JSWeakObjectMapRefPrivate.cpp in Sources */,
    24882519                                86D08D5311793613006E5ED0 /* WTFThreadData.cpp in Sources */,
     2520                                868BFA08117CEFD100B908B1 /* AtomicString.cpp in Sources */,
     2521                                868BFA0E117CEFD100B908B1 /* StringImpl.cpp in Sources */,
     2522                                868BFA17117CF19900B908B1 /* WTFString.cpp in Sources */,
    24892523                        );
    24902524                        runOnlyForDeploymentPostprocessing = 0;
Note: See TracChangeset for help on using the changeset viewer.