Changeset 58091 in webkit for trunk/JavaScriptCore/assembler/ARMAssembler.cpp

Timestamp:

Apr 22, 2010, 6:24:56 AM (15 years ago)

Author:

[email protected]

Message:

2010-04-22 Gabor Loki <​[email protected]>

Reviewed by Gavin Barraclough.

Use BLX and BX to keep happy the return stack predictor above ARMv4
​https://bugs.webkit.org/show_bug.cgi?id=37862

Inspired by Jacob Bramley's patch from JaegerMonkey

• assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
• assembler/ARMAssembler.h: (JSC::ARMAssembler::): (JSC::ARMAssembler::bx): (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::getLdrImmAddress):
• assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):

File:

• trunk/JavaScriptCore/assembler/ARMAssembler.cpp (modified) (1 diff)

trunk/JavaScriptCore/assembler/ARMAssembler.cpp

@@ -358 +358 @@
         ARMWord* ldrAddr = reinterpret_cast<ARMWord*>(data + pos);
         ARMWord* addr = getLdrImmAddress(ldrAddr);
-        if (*addr != 0xffffffff) {
+        if (*addr != InvalidBranchTarget) {
             if (!(*iter & 1)) {
                 int diff = reinterpret_cast<ARMWord*>(data + *addr) - (ldrAddr + DefaultPrefetching);