Changeset 59005 in webkit for trunk/JavaScriptCore/jit/JITOpcodes.cpp

Timestamp:

May 8, 2010, 12:14:29 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-08 Eric Seidel <​[email protected]>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
​https://bugs.webkit.org/show_bug.cgi?id=38798

• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve):
• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global):

2010-05-08 Eric Seidel <​[email protected]>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
​https://bugs.webkit.org/show_bug.cgi?id=38798

• fast/js/global-resolve-through-eval-expected.txt: Added.
• fast/js/global-resolve-through-eval.html: Added.
• fast/js/script-tests/global-resolve-through-eval.js: Added. (accessGlobal): (accessLocal):
• platform/win/Skipped:

2010-05-08 Eric Seidel <​[email protected]>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
​https://bugs.webkit.org/show_bug.cgi?id=38798

Test: fast/js/global-resolve-through-eval.html

• bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): (WebCore::DeleteCallbackDataTask::create): (WebCore::DeleteCallbackDataTask::performTask): (WebCore::DeleteCallbackDataTask::isCleanupTask): (WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
• bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
• bindings/js/JSCustomVoidCallback.h:
• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::):
• bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::):
• workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask):

2010-05-08 Eric Seidel <​[email protected]>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
​https://bugs.webkit.org/show_bug.cgi?id=38798

• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/common/system/executive_unittest.py:
• Scripts/webkitpy/layout_tests/port/chromium_linux.py:
• Scripts/webkitpy/layout_tests/port/chromium_mac.py:
• Scripts/webkitpy/layout_tests/port/chromium_win.py:
• Scripts/webkitpy/layout_tests/port/mac.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
• Scripts/webkitpy/layout_tests/port/win.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
• Scripts/webkitpy/tool/commands/download.py:
• Scripts/webkitpy/tool/commands/download_unittest.py:

File:

• trunk/JavaScriptCore/jit/JITOpcodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/jit/JITOpcodes.cpp

@@ -732 +732 @@
     load32(BaseIndex(regT2, regT3, TimesEight, 4), regT1); // tag
     emitStore(dst, regT1, regT0);
-    map(m_bytecodeIndex + OPCODE_LENGTH(dynamic ? op_resolve_global_dynamic : op_resolve_global), dst, regT1, regT0);
+    map(m_bytecodeIndex + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
 }