Changeset 59056 in webkit for trunk/JavaScriptCore/jit/JITOpcodes.cpp

Timestamp:

May 9, 2010, 4:42:22 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-09 Oliver Hunt <​[email protected]>

Reviewed by Maciej Stachowiak.

Improve string indexing performance
​https://bugs.webkit.org/show_bug.cgi?id=38814

Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.

• jit/JIT.h:
• jit/JITInlineMethods.h:
• jit/JITOpcodes.cpp:
• jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):

Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.

• jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
• jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitFastArithImmToInt):

File:

• trunk/JavaScriptCore/jit/JITOpcodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/jit/JITOpcodes.cpp

@@ -1408 +1408 @@
 }
 
-void JIT::emitSlow_op_get_by_val(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter)
-{
-    unsigned dst = currentInstruction[1].u.operand;
-    unsigned base = currentInstruction[2].u.operand;
-    unsigned property = currentInstruction[3].u.operand;
-
-    linkSlowCase(iter); // property int32 check
-    linkSlowCaseIfNotJSCell(iter, base); // base cell check
-    linkSlowCase(iter); // base array check
-    linkSlowCase(iter); // vector length check
-    linkSlowCase(iter); // empty value
-
-    JITStubCall stubCall(this, cti_op_get_by_val);
-    stubCall.addArgument(base, regT2);
-    stubCall.addArgument(property, regT2);
-    stubCall.call(dst);
-}
-
 void JIT::emitSlow_op_loop_if_lesseq(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter)
 {