Changeset 59196 in webkit for trunk/JavaScriptCore/JavaScriptCore.exp

Timestamp:

May 11, 2010, 7:25:40 PM (15 years ago)

Author:

[email protected]

Message:

Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

• JavaScriptCore.exp: Remove exports of inline functions.
• wtf/text/AtomicString.cpp:

(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path

of add.

• wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Inline the fast path of add.

• wtf/text/CString.cpp: Inline implementation of data and length in the header.
• wtf/text/CString.h:

(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.

• wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
• wtf/text/WTFString.h:

(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

File:

• trunk/JavaScriptCore/JavaScriptCore.exp (modified) (6 diffs)

trunk/JavaScriptCore/JavaScriptCore.exp

@@ +1 @@
+__ZN7WebCore10StringImpl6createEPKcj
+__ZN7WebCore12AtomicString11addSlowCaseEPNS_10StringImplE
 _JSCheckScriptSyntax
 _JSClassCreate
@@ -406 +408 @@
 __ZN7WebCore12AtomicString3addEPKtj
 __ZN7WebCore12AtomicString3addEPKtjj
-__ZN7WebCore12AtomicString3addEPNS_10StringImplE
 __ZN7WebCore12AtomicString4findEPKtjj
 __ZN7WebCore12AtomicString4initEv
@@ -440 +441 @@
 __ZN7WebCore6String8fromUTF8EPKcm
 __ZN7WebCore6String8truncateEj
-__ZN7WebCore6StringC1EPKc
-__ZN7WebCore6StringC1EPKcj
 __ZN7WebCore6StringC1EPKt
-__ZN7WebCore6StringC1EPKtj
 __ZN7WebCore7xmlAtomE
 __ZN7WebCore8nullAtomE
@@ -511 +509 @@
 __ZNK3JSC9HashTable11createTableEPNS_12JSGlobalDataE
 __ZNK3JSC9HashTable11deleteTableEv
-__ZNK3WTF7CString4dataEv
-__ZNK3WTF7CString6lengthEv
 __ZNK3WTF8Collator7collateEPKtmS2_m
 __ZNK7WebCore12AtomicString5lowerEv
-__ZNK7WebCore6String10charactersEv
 __ZNK7WebCore6String11toIntStrictEPbi
 __ZNK7WebCore6String12toUIntStrictEPbi
@@ -534 +529 @@
 __ZNK7WebCore6String5upperEv
 __ZNK7WebCore6String6latin1Ev
-__ZNK7WebCore6String6lengthEv
 __ZNK7WebCore6String6toUIntEPb
-__ZNK7WebCore6String7isEmptyEv
 __ZNK7WebCore6String7toFloatEPb
 __ZNK7WebCore6String8foldCaseEv
@@ -543 +536 @@
 __ZNK7WebCore6String8toUInt64EPb
 __ZNK7WebCore6String9substringEjj
-__ZNK7WebCore6StringixEj
 __ZTVN3JSC12StringObjectE
 __ZTVN3JSC14JSGlobalObjectE