Changeset 59196 in webkit for trunk/JavaScriptCore/wtf/text/AtomicString.h

Timestamp:

May 11, 2010, 7:25:40 PM (15 years ago)

Author:

[email protected]

Message:

Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

• JavaScriptCore.exp: Remove exports of inline functions.
• wtf/text/AtomicString.cpp:

(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path

of add.

• wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Inline the fast path of add.

• wtf/text/CString.cpp: Inline implementation of data and length in the header.
• wtf/text/CString.h:

(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.

• wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
• wtf/text/WTFString.h:

(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

File:

• trunk/JavaScriptCore/wtf/text/AtomicString.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/text/AtomicString.h

@@ -118 +118 @@
     static PassRefPtr<StringImpl> add(const UChar*, unsigned length, unsigned existingHash);
     static PassRefPtr<StringImpl> add(const UChar*);
-    static PassRefPtr<StringImpl> add(StringImpl*);
+    PassRefPtr<StringImpl> add(StringImpl* r)
+    {
+        if (!r || r->isAtomic())
+            return r;
+        return addSlowCase(r);
+    }
+    static PassRefPtr<StringImpl> addSlowCase(StringImpl*);
 };