Changeset 59355 in webkit for trunk/JavaScriptCore/runtime/RegExp.cpp

Timestamp:

May 13, 2010, 2:36:54 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-13 Maciej Stachowiak <​[email protected]>

Reviewed by Mark Rowe.

Various JavaScript string optimizations
​https://bugs.webkit.org/show_bug.cgi?id=39051

Approximately 1% SunSpider speedup.

• runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
• runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
• runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
• runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.

File:

• trunk/JavaScriptCore/runtime/RegExp.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/RegExp.cpp

@@ -108 +108 @@
         startOffset = 0;
     if (ovector)
-        ovector->clear();
+        ovector->resize(0);
 
     if (static_cast<unsigned>(startOffset) > s.size() || s.isNull())
@@ -132 +132 @@
         for (int j = 0; j < offsetVectorSize; ++j)
             offsetVector[j] = -1;
-
 
 #if ENABLE(YARR_JIT)