Changeset 59746 in webkit for trunk/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

May 18, 2010, 11:04:18 PM (15 years ago)

Author:

[email protected]

Message:

Bug 39343 - Dynamically generate a native call thunk per NativeFunction

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call. By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.

• jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

• jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

• jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

• jit/JITStubs.h:
• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

• jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

• runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

• runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

• runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

• runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

• wtf/Platform.h:

File:

• trunk/JavaScriptCore/jit/JITStubs.cpp (modified) (2 diffs)

trunk/JavaScriptCore/jit/JITStubs.cpp

@@ -3405 +3405 @@
 }
 
-MacroAssemblerCodePtr JITThunks::specializedThunk(JSGlobalData* globalData, ThunkGenerator generator)
-{
-    std::pair<ThunkMap::iterator, bool> entry = m_thunkMap.add(generator, MacroAssemblerCodePtr());
+MacroAssemblerCodePtr JITThunks::ctiStub(JSGlobalData* globalData, ThunkGenerator generator)
+{
+    std::pair<CTIStubMap::iterator, bool> entry = m_ctiStubMap.add(generator, MacroAssemblerCodePtr());
     if (entry.second)
         entry.first->second = generator(globalData, m_executablePool.get());
@@ -3413 +3413 @@
 }
 
+PassRefPtr<NativeExecutable> JITThunks::hostFunctionStub(JSGlobalData* globalData, NativeFunction function)
+{
+    std::pair<HostFunctionStubMap::iterator, bool> entry = m_hostFunctionStubMap.add(function, 0);
+    if (entry.second)
+        entry.first->second = NativeExecutable::create(JIT::compileCTINativeCall(globalData, m_executablePool, function), function);
+    return entry.first->second;
+}
+
+PassRefPtr<NativeExecutable> JITThunks::hostFunctionStub(JSGlobalData* globalData, NativeFunction function, ThunkGenerator generator)
+{
+    std::pair<HostFunctionStubMap::iterator, bool> entry = m_hostFunctionStubMap.add(function, 0);
+    if (entry.second)
+        entry.first->second = NativeExecutable::create(generator(globalData, m_executablePool.get()), function);
+    return entry.first->second;
+}
+
 } // namespace JSC