Ignore:
Timestamp:
May 21, 2010, 4:06:09 PM (15 years ago)
Author:
[email protected]
Message:

Enforce size constraints on various data structures in JavaScriptCore/wtf.
https://bugs.webkit.org/show_bug.cgi?id=39327

Reviewed by Darin Adler.

I only modified the default build for OSX and Chromium's build file to include WTFCompileAsserts.cpp
as those should be sufficient to catch regressions on the size of the data structures.

  • JavaScriptCore.gypi: Added the WTFCompileAsserts.cpp file.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added the WTFCompileAsserts.cpp file.
  • runtime/UString.cpp: Added a compile assert for UString size.
  • wtf/SizeLimits.cpp: Added compile asserts for data structures that didn't have cpp files.
  • wtf/text/StringImpl.cpp: Added a compile assert for StringImpl size.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r59955 r59969  
    4444                0BDFFAE00FC6192900D69EF4 /* CrossThreadRefCounted.h in Headers */ = {isa = PBXBuildFile; fileRef = 0BDFFAD40FC6171000D69EF4 /* CrossThreadRefCounted.h */; settings = {ATTRIBUTES = (Private, ); }; };
    4545                0BDFFAE10FC6193100D69EF4 /* OwnFastMallocPtr.h in Headers */ = {isa = PBXBuildFile; fileRef = 0BDFFAD10FC616EC00D69EF4 /* OwnFastMallocPtr.h */; settings = {ATTRIBUTES = (Private, ); }; };
     46                0BF28A2911A33DC300638F84 /* SizeLimits.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0BF28A2811A33DC300638F84 /* SizeLimits.cpp */; };
    4647                14035DB110DBFB2A00FFFFE7 /* WeakGCPtr.h in Headers */ = {isa = PBXBuildFile; fileRef = 14035DB010DBFB2A00FFFFE7 /* WeakGCPtr.h */; settings = {ATTRIBUTES = (Private, ); }; };
    4748                140566C4107EC255005DBC8D /* JSAPIValueWrapper.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC0894D50FAFBA2D00001865 /* JSAPIValueWrapper.cpp */; };
     
    596597                0BDFFAD10FC616EC00D69EF4 /* OwnFastMallocPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OwnFastMallocPtr.h; sourceTree = "<group>"; };
    597598                0BDFFAD40FC6171000D69EF4 /* CrossThreadRefCounted.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CrossThreadRefCounted.h; sourceTree = "<group>"; };
     599                0BF28A2811A33DC300638F84 /* SizeLimits.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SizeLimits.cpp; sourceTree = "<group>"; };
    598600                14035DB010DBFB2A00FFFFE7 /* WeakGCPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WeakGCPtr.h; sourceTree = "<group>"; };
    599601                140D17D60E8AD4A9000CD17D /* JSBasePrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSBasePrivate.h; sourceTree = "<group>"; };
     
    14411443                                148A1ECD0D10C23B0069A47C /* RefPtrHashMap.h */,
    14421444                                51F648D60BB4E2CA0033D760 /* RetainPtr.h */,
     1445                                0BF28A2811A33DC300638F84 /* SizeLimits.cpp */,
    14431446                                969A07290ED1CE6900F1F681 /* SegmentedVector.h */,
    14441447                                868BFA5F117D048200B908B1 /* StaticConstructors.h */,
     
    26002603                                86565742115BE3DA00291F40 /* CString.cpp in Sources */,
    26012604                                A7482B9411671147003B0712 /* JSWeakObjectMapRefPrivate.cpp in Sources */,
     2605                                0BF28A2911A33DC300638F84 /* SizeLimits.cpp in Sources */,
    26022606                                86D08D5311793613006E5ED0 /* WTFThreadData.cpp in Sources */,
    26032607                                868BFA08117CEFD100B908B1 /* AtomicString.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.