Changeset 61430 in webkit for trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h

Timestamp:

Jun 18, 2010, 1:14:23 PM (15 years ago)

Author:

[email protected]

Message:

2010-06-17 Oliver Hunt <​[email protected]>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
​https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

• bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
• bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):

File:

• trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h (modified) (2 diffs)

trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h

@@ -364 +364 @@
 
         RegisterID* emitCatch(RegisterID*, Label* start, Label* end);
-        void emitThrow(RegisterID* exc) { emitUnaryNoDstOp(op_throw, exc); }
+        void emitThrow(RegisterID* exc)
+        { 
+            m_usesExceptions = true;
+            emitUnaryNoDstOp(op_throw, exc);
+        }
+
         RegisterID* emitNewError(RegisterID* dst, bool isReferenceError, JSValue message);
         void emitPushNewScope(RegisterID* dst, const Identifier& property, RegisterID* value);
@@ -553 +558 @@
         unsigned m_emitNodeDepth;
 
+        bool m_usesExceptions;
         bool m_regeneratingForExceptionInfo;
         CodeBlock* m_codeBlockBeingRegeneratedFrom;