Changeset 61623 in webkit for trunk/JavaScriptCore/bytecompiler/NodesCodegen.cpp

Timestamp:

Jun 22, 2010, 12:16:57 PM (15 years ago)

Author:

[email protected]

Message:

Adding regular expression caching to JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=38142

Patch by Renata Hodovan <​[email protected]> on 2010-06-22
Reviewed by Geoffrey Garen.

The cache is based on Round Robin eviction policy, and
can cache at most 256 character long regular expressions,
and at most 256 of them. These values can be changed at compile time.

• GNUmakefile.am:
• JavaScriptCore.gypi:
• JavaScriptCore.pro:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

• runtime/JSGlobalData.h:

(JSC::JSGlobalData::regExpCache):

• runtime/RegExpCache.cpp: Added.

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
(JSC::RegExpCache::RegExpCache):

• runtime/RegExpCache.h: Added.
• runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

• runtime/RegExpKey.h: Added.

(JSC::RegExpKey::RegExpKey):
(JSC::RegExpKey::getFlagsValue):
(WTF::operator==):
(WTF::):

• runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

File:

• trunk/JavaScriptCore/bytecompiler/NodesCodegen.cpp (modified) (2 diffs)

trunk/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -40 +40 @@
 #include "Parser.h"
 #include "PropertyNameArray.h"
+#include "RegExpCache.h"
 #include "RegExpObject.h"
 #include "SamplingTool.h"
@@ -145 +146 @@
 RegisterID* RegExpNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
 {
-    RefPtr<RegExp> regExp = RegExp::create(generator.globalData(), m_pattern.ustring(), m_flags.ustring());
+    RefPtr<RegExp> regExp = generator.globalData()->regExpCache()->lookupOrCreate(m_pattern.ustring(), m_flags.ustring());
     if (!regExp->isValid())
         return emitThrowError(generator, false, "Invalid regular expression: %s", regExp->errorMessage());