Changeset 61833 in webkit for trunk/JavaScriptCore/runtime/RegExpCache.h

Timestamp:

Jun 24, 2010, 11:33:48 PM (15 years ago)

Author:

[email protected]

Message:

Merge RegExp constructor and RegExp::create methods into one.
Both of function are called with tree parameters and check whether
flags (the third param) is given or not.
Simplify hash lookups in RegExpCache::create with giving them an extra
iterator parameter.
​https://bugs.webkit.org/show_bug.cgi?id=41055

Patch by Renata Hodovan <​[email protected]> on 2010-06-24
Reviewed by Geoffrey Garen.

• runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

• runtime/RegExp.h:
• runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

• runtime/RegExpCache.h:

File:

• trunk/JavaScriptCore/runtime/RegExpCache.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/RegExpCache.h

@@ -36 +36 @@
 
 class RegExpCache {
+
+typedef HashMap<RegExpKey, RefPtr<RegExp> > RegExpCacheMap;
+
 public:
     PassRefPtr<RegExp> lookupOrCreate(const UString& patternString, const UString& flags);
-    PassRefPtr<RegExp> create(const UString& patternString, const UString& flags);
+    PassRefPtr<RegExp> create(const UString& patternString, const UString& flags, RegExpCacheMap::iterator iterator);
     RegExpCache(JSGlobalData* globalData);
 
@@ -45 +48 @@
     static const int maxCacheableEntries = 256;
 
-    typedef HashMap<RegExpKey, RefPtr<RegExp> > RegExpCacheMap;
     RegExpKey patternKeyArray[maxCacheableEntries];
     RegExpCacheMap m_cacheMap;