Changeset 62367 in webkit for trunk/JavaScriptCore/runtime/Collector.cpp

Timestamp:

Jul 1, 2010, 11:31:27 PM (15 years ago)

Author:

[email protected]

Message:

2010-07-01 Oliver Hunt <​[email protected]>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
​https://bugs.webkit.org/show_bug.cgi?id=41506

This new type is used in place of fixed length C arrays so
that debug builds can guard against attempts to go beyond
the end of the array.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
• pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
• runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::allocate):
• runtime/Collector.h: (JSC::CollectorBitmap::clearAll):
• runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::operator*):
• runtime/DateInstanceCache.h:
• runtime/JSString.cpp: (JSC::JSString::replaceCharacter):
• runtime/JSString.h: (JSC::RopeBuilder::JSStringFinalizerStruct::):
• runtime/NumericStrings.h:
• runtime/RegExpCache.h:
• runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
• wtf/AVLTree.h:
• wtf/FixedArray.h: Added. (WTF::FixedArray::operator[]): (WTF::FixedArray::data):

2010-07-01 Oliver Hunt <​[email protected]>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
​https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header.

• ForwardingHeaders/wtf/FixedArray.h: Added.

2010-07-01 Oliver Hunt <​[email protected]>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
​https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header, and replace a few fixed length arrays
with the new FixedArray type.

• ForwardingHeaders/wtf/FixedArray.h: Added.
• dom/Document.h:
• platform/graphics/GlyphMetricsMap.h:

File:

• trunk/JavaScriptCore/runtime/Collector.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Collector.cpp

@@ -246 +246 @@
     Structure* dummyMarkableCellStructure = m_globalData->dummyMarkableCellStructure.get();
     for (size_t i = 0; i < HeapConstants::cellsPerBlock; ++i)
-        new (block->cells + i) JSCell(dummyMarkableCellStructure);
+        new (&block->cells[i]) JSCell(dummyMarkableCellStructure);
     
     // Add block to blocks vector.
@@ -385 +385 @@
             ASSERT(m_heap.nextCell < HeapConstants::cellsPerBlock);
             if (!block->marked.get(m_heap.nextCell)) { // Always false for the last cell in the block
-                Cell* cell = block->cells + m_heap.nextCell;
+                Cell* cell = &block->cells[m_heap.nextCell];
 
                 m_heap.operationInProgress = Allocation;