Changeset 62414 in webkit for trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

Timestamp:

Jul 2, 2010, 4:26:23 PM (15 years ago)

Author:

[email protected]

Message:

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41548
Use snprintf instead of sprintf everywhere in JavaScriptCore

Reviewed by Geoffrey Garen.

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncEscape):

• runtime/UString.cpp:

(JSC::UString::from):

File:

• trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (modified) (3 diffs)

trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -67 +67 @@
         else {
             char tmp[4];
-            snprintf(tmp, 4, "%%%02X", static_cast<unsigned char>(c));
+            snprintf(tmp, sizeof(tmp), "%%%02X", static_cast<unsigned char>(c));
             builder.append(tmp);
         }
@@ -387 +387 @@
         if (u > 255) {
             char tmp[7];
-            sprintf(tmp, "%%u%04X", u);
+            snprintf(tmp, sizeof(tmp), "%%u%04X", u);
             builder.append(tmp);
         } else if (u != 0 && strchr(do_not_escape, static_cast<char>(u)))
@@ -393 +393 @@
         else {
             char tmp[4];
-            sprintf(tmp, "%%%02X", u);
+            snprintf(tmp, sizeof(tmp), "%%%02X", u);
             builder.append(tmp);
         }