Changeset 62419 in webkit for trunk/JavaScriptCore/runtime/JSImmediate.h

Timestamp:

Jul 2, 2010, 5:28:12 PM (15 years ago)

Author:

[email protected]

Message:

Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.

Reviewed by Oliver Hunt.

Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).

• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):

• runtime/JSImmediate.h:

(JSC::JSValue::isCell):

File:

• trunk/JavaScriptCore/runtime/JSImmediate.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSImmediate.h

@@ -44 +44 @@
     class JSObject;
     class UString;
-
-    extern const size_t CELL_MASK;
 
 #if USE(JSVALUE64)
@@ -598 +596 @@
     inline bool JSValue::isCell() const
     {
-#ifndef NDEBUG
-        bool r = !JSImmediate::isImmediate(asValue());
-        ASSERT(!r || !(JSImmediate::rawValue(asValue()) & CELL_MASK));
-        return r;
-#else
         return !JSImmediate::isImmediate(asValue());
-#endif
     }