Changeset 62677 in webkit for trunk/JavaScriptCore/yarr/RegexInterpreter.h

Timestamp:

Jul 7, 2010, 9:53:49 AM (15 years ago)

Author:

Darin Adler

Message:

2010-07-07 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

More OwnPtr work
​https://bugs.webkit.org/show_bug.cgi?id=41727

• API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): Use adoptPtr.
• API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::JSCallbackObject): Ditto.
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): Ditto.
• bytecode/CodeBlock.h: (JSC::CodeBlock::createRareDataIfNecessary): Ditto.
• parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): Ditto.
• parser/ParserArena.cpp: (JSC::ParserArena::ParserArena): Ditto.
• runtime/Arguments.h: (JSC::Arguments::Arguments): Ditto.
• runtime/Executable.cpp: (JSC::EvalExecutable::compile): Ditto. (JSC::ProgramExecutable::compile): Ditto. (JSC::FunctionExecutable::compileForCall): Ditto. (JSC::FunctionExecutable::compileForConstruct): Ditto. (JSC::FunctionExecutable::reparseExceptionInfo): Ditto. (JSC::EvalExecutable::reparseExceptionInfo): Ditto.
• runtime/JSArray.cpp: (JSC::JSArray::sort): Ditto.
• runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): Ditto.
• runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): Ditto.
• runtime/SmallStrings.cpp: (JSC::SmallStrings::createSingleCharacterString): Ditto. (JSC::SmallStrings::singleCharacterStringRep): Ditto.

• wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault): Use adoptPtr.
• yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::ByteCompiler): Ditto. (JSC::Yarr::ByteCompiler::compile): Ditto. (JSC::Yarr::ByteCompiler::regexBegin): Ditto. (JSC::Yarr::byteCompileRegex): Ditto.
• yarr/RegexInterpreter.h: (JSC::Yarr::BytecodePattern::BytecodePattern): Ditto.

2010-07-06 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

More OwnPtr work, including making clear set the pointer to 0 before deletion
​https://bugs.webkit.org/show_bug.cgi?id=41727

• WebCore.exp.in: Updated.

• css/CSSSelector.h: (WebCore::CSSSelector::RareData::RareData): Use adoptPtr. (WebCore::CSSSelector::createRareData): Ditto.
• dom/SpaceSplitString.h: (WebCore::SpaceSplitString::SpaceSplitString): Ditto. (WebCore::SpaceSplitString::set): Ditto.
• history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Ditto. (WebCore::CachedFrame::setCachedFramePlatformData): Ditto.

• history/CachedFrame.h: Use PassOwnPtr.

• loader/appcache/ApplicationCacheGroup.cpp: (WebCore::CallCacheListenerTask::create): Use adoptPtr.
• loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
• platform/PurgeableBuffer.h: (WebCore::PurgeableBuffer::create): Ditto.
• platform/graphics/GlyphMetricsMap.h: (WebCore::::locatePageSlowCase): Ditto.
• platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue::AnimationValue): Ditto. (WebCore::TransformAnimationValue::TransformAnimationValue): Ditto.
• platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): Ditto.
• platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::boundsForGlyph): Ditto.
• platform/mac/PurgeableBufferMac.cpp: (WebCore::PurgeableBuffer::create): Ditto.
• rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::setHorizontalOverflowPositions): Ditto. (WebCore::InlineFlowBox::setVerticalOverflowPositions): Ditto.
• rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): Ditto.
• rendering/style/RenderStyle.h: (WebCore::InheritedFlags::inheritAnimations): Ditto. (WebCore::InheritedFlags::inheritTransitions): Ditto.

• rendering/style/SVGRenderStyleDefs.h: Use PassOwnPtr.

File:

• trunk/JavaScriptCore/yarr/RegexInterpreter.h (modified) (4 diffs)

trunk/JavaScriptCore/yarr/RegexInterpreter.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -31 +31 @@
 #include "RegexParser.h"
 #include "RegexPattern.h"
+#include <wtf/PassOwnPtr.h>
 #include <wtf/unicode/Unicode.h>
 
@@ -293 +294 @@
 
 struct BytecodePattern : FastAllocBase {
-    BytecodePattern(ByteDisjunction* body, Vector<ByteDisjunction*> allParenthesesInfo, RegexPattern& pattern)
+    BytecodePattern(PassOwnPtr<ByteDisjunction> body, Vector<ByteDisjunction*> allParenthesesInfo, RegexPattern& pattern)
         : m_body(body)
         , m_ignoreCase(pattern.m_ignoreCase)
@@ -326 +327 @@
 };
 
-BytecodePattern* byteCompileRegex(const UString& pattern, unsigned& numSubpatterns, const char*& error, bool ignoreCase = false, bool multiline = false);
+PassOwnPtr<BytecodePattern> byteCompileRegex(const UString& pattern, unsigned& numSubpatterns, const char*& error, bool ignoreCase = false, bool multiline = false);
 int interpretRegex(BytecodePattern* v_regex, const UChar* input, unsigned start, unsigned length, int* output);