Changeset 62697 in webkit for trunk/JavaScriptCore/wtf/Vector.h

Timestamp:

Jul 7, 2010, 2:21:08 PM (15 years ago)

Author:

[email protected]

Message:

2010-07-07 Adam Barth <​[email protected]>

Reviewed by Sam Weinig.

Add reverseFind to Vector and deploy in HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=41778

This method seems generally useful. I'm slightly surprised we don't
have it already.

• wtf/Vector.h: (WTF::::reverseFind):

2010-07-07 Adam Barth <​[email protected]>

Reviewed by Sam Weinig.

Add reverseFind to Vector and deploy in HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=41778

This patch moves reverseFind from begin an
HTMLFormattingElementList-specific concept to begin a general Vector
concept. Also, instead of using Entry as the type for operator==, we
now use elements directly. The old code compiled because the Entry
constructor wasn't explicit, which means we were churning refs on every
comparison!

• html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::bookmarkFor): (WebCore::HTMLFormattingElementList::insertAt): (WebCore::HTMLFormattingElementList::remove):
• html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::Entry::operator==): (WebCore::HTMLFormattingElementList::Entry::operator!=):

File:

• trunk/JavaScriptCore/wtf/Vector.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/Vector.h

@@ -558 +558 @@
 
         template<typename U> size_t find(const U&) const;
+        template<typename U> size_t reverseFind(const U&) const;
 
         void shrink(size_t size);
@@ -740 +741 @@
             if (at(i) == value)
                 return i;
+        }
+        return notFound;
+    }
+
+    template<typename T, size_t inlineCapacity>
+    template<typename U>
+    size_t Vector<T, inlineCapacity>::reverseFind(const U& value) const
+    {
+        for (size_t i = 1; i <= size(); ++i) {
+            const size_t index = size() - i;
+            if (at(index) == value)
+                return index;
         }
         return notFound;