Changeset 62727 in webkit for trunk/JavaScriptCore/parser/JSParser.cpp

Timestamp:

Jul 7, 2010, 4:27:57 PM (15 years ago)

Author:

[email protected]

Message:

2010-07-07 Oliver Hunt <​[email protected]>

Reviewed by Geoffrey Garen.

Lazy mode of parser allows invalid syntax in object literals.
​https://bugs.webkit.org/show_bug.cgi?id=41809

Make the parser itself validate getter and setter syntax rather
than offloading it to the AST builder.

• parser/ASTBuilder.h: (JSC::ASTBuilder::createGetterOrSetterProperty):
• parser/JSParser.cpp: (JSC::JSParser::parseProperty):

File:

• trunk/JavaScriptCore/parser/JSParser.cpp (modified) (1 diff)

trunk/JavaScriptCore/parser/JSParser.cpp

@@ -1169 +1169 @@
         int closeBracePos = 0;
         int bodyStartLine = 0;
+        failIfFalse(*ident == m_globalData->propertyNames->get || *ident == m_globalData->propertyNames->set);
         failIfFalse(parseFunctionInfo<FunctionNeedsName>(context, accessorName, parameters, body, openBracePos, closeBracePos, bodyStartLine));
         return context.createGetterOrSetterProperty(ident, accessorName, parameters, body, openBracePos, closeBracePos, bodyStartLine, m_lastLine);