Changeset 63103 in webkit for trunk/JavaScriptCore

Timestamp:

Jul 12, 2010, 12:21:56 PM (15 years ago)

Author:

Adam Roben

Message:

Stop generating stripped symbols for Release builds

It turns out we can strip the symbols after-the-fact using PDBCopy.

Fixes <​http://webkit.org/b/42085>.

Reviewed by Steve Falkenburg.

JavaScriptCore:

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:

Removed the pre-link event, which just created the public\sym
directory.

WebKit2:

• win/WebKit2.vcproj: Removed the no-longer-needed Release override of

the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)

WebKitLibraries:

• win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols

attribute, which caused link.exe to generate a stripped PDB file for
each project.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-07-12  Adam Roben  <[email protected]>
+
+        Stop generating stripped symbols for Release builds
+
+        It turns out we can strip the symbols after-the-fact using PDBCopy.
+
+        Fixes <http://webkit.org/b/42085>.
+
+        Reviewed by Steve Falkenburg.
+
+        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
+        Removed the pre-link event, which just created the public\sym
+        directory.
+
 2010-07-12  Anders Carlsson  <[email protected]>
 

trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops

@@ -24 +24 @@
                 CommandLine="%SystemDrive%\cygwin\bin\which.exe bash
if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%
cmd /c
if exist "$(WebKitOutputDir)\buildfailed" grep XX$(ProjectName)XX "$(WebKitOutputDir)\buildfailed"
if errorlevel 1 exit 1
echo XX$(ProjectName)XX > "$(WebKitOutputDir)\buildfailed"

bash "$(WebKitLibrariesDir)\tools\scripts\auto-version.sh" "$(IntDir)"
"
         />
-        <Tool
-                Name="VCPreLinkEventTool"
-                CommandLine="if not exist &quot;$(WebKitOutputDir)\public\sym&quot; mkdir &quot;$(WebKitOutputDir)\public\sym&quot;"
-        />
 </VisualStudioPropertySheet>