Changeset 63093 in webkit for trunk/JavaScriptCore


Ignore:
Timestamp:
Jul 12, 2010, 9:41:13 AM (15 years ago)
Author:
[email protected]
Message:

Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
​https://bugs.webkit.org/show_bug.cgi?id=42086

Reviewed by Dan Bernstein.

  • wtf/OwnPtr.h:
  • wtf/PassOwnPtr.h:
  • wtf/PassRefPtr.h:

(WTF::PassRefPtr::releaseRef):
(WTF::NonNullPassRefPtr::leakRef):
(WTF::NonNullPassRefPtr::releaseRef):

  • wtf/RetainPtr.h:

(WTF::RetainPtr::releaseRef):

Location:
trunk/JavaScriptCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r63056 r63093  
     12010-07-12  Anders Carlsson  <[email protected]>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
     6        https://bugs.webkit.org/show_bug.cgi?id=42086
     7
     8        * wtf/OwnPtr.h:
     9        * wtf/PassOwnPtr.h:
     10        * wtf/PassRefPtr.h:
     11        (WTF::PassRefPtr::releaseRef):
     12        (WTF::NonNullPassRefPtr::leakRef):
     13        (WTF::NonNullPassRefPtr::releaseRef):
     14        * wtf/RetainPtr.h:
     15        (WTF::RetainPtr::releaseRef):
     16
    1172010-07-10  Oliver Hunt  <[email protected]>
    218

  • trunk/JavaScriptCore/wtf/OwnPtr.h

    r62674 r63093  
    6161        void clear();
    6262        PassOwnPtr<T> release();
    63         PtrType leakPtr();
     63        PtrType leakPtr() WARN_UNUSED_RETURN;
    6464
    6565        ValueType& operator*() const { ASSERT(m_ptr); return *m_ptr; }

  • trunk/JavaScriptCore/wtf/PassOwnPtr.h

    r62674 r63093  
    6060
    6161        void clear();
    62         PtrType leakPtr() const;
     62        PtrType leakPtr() const WARN_UNUSED_RETURN;
    6363
    6464        ValueType& operator*() const { ASSERT(m_ptr); return *m_ptr; }

  • trunk/JavaScriptCore/wtf/PassRefPtr.h

    r62674 r63093  
    7878
    7979        void clear();
    80         T* leakRef() const;
     80        T* leakRef() const WARN_UNUSED_RETURN;
    8181
    8282        T& operator*() const { return *m_ptr; }
    … …  
    9797
    9898        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
    99         T* releaseRef() const { return leakRef(); }
     99        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
    100100
    101101    private:
    … …  
    153153
    154154        void clear();
    155         T* leakRef() const { T* tmp = m_ptr; m_ptr = 0; return tmp; }
     155        T* leakRef() const { T* tmp = m_ptr; m_ptr = 0; return tmp; } WARN_UNUSED_RETURN;
    156156
    157157        T& operator*() const { return *m_ptr; }
    … …  
    159159
    160160        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
    161         T* releaseRef() const { return leakRef(); }
     161        T* releaseRef() const { return leakRef(); } WARN_UNUSED_RETURN;
    162162
    163163    private:

  • trunk/JavaScriptCore/wtf/RetainPtr.h

    r61576 r63093  
    7272        PtrType get() const { return m_ptr; }
    7373       
    74         PtrType releaseRef() { PtrType tmp = m_ptr; m_ptr = 0; return tmp; }
     74        PtrType releaseRef() { PtrType tmp = m_ptr; m_ptr = 0; return tmp; } WARN_UNUSED_RETURN;
    7575       
    7676        PtrType operator->() const { return m_ptr; }
Note: See TracChangeset for help on using the changeset viewer.