Changeset 64302 in webkit for trunk/JavaScriptCore/wtf/FastMalloc.cpp

Timestamp:

Jul 29, 2010, 12:52:22 PM (15 years ago)

Author:

Csaba Osztrogonác

Message:

2010-07-29 Gabor Loki <​[email protected]>

Reviewed by Gavin Barraclough.

Avoid increasing required alignment of target type warning on ARM
​https://bugs.webkit.org/show_bug.cgi?id=38045

The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
increases required alignment of target type warnings.
Casting the type of [pointer to Type2] object to void* bypasses the
warning.

• assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
• assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putShortUnchecked): (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt64Unchecked):
• jit/JITStubs.cpp:
• pcre/pcre_compile.cpp: (jsRegExpCompile):
• wtf/FastMalloc.cpp: (WTF::PageHeapAllocator::New): (WTF::TCMalloc_Central_FreeList::Populate):
• wtf/MD5.cpp: (WTF::reverseBytes): (WTF::MD5::addBytes): (WTF::MD5::checksum):
• wtf/StdLibExtras.h: (reinterpret_cast_ptr):
• wtf/Vector.h: (WTF::VectorBuffer::inlineBuffer):
• wtf/qt/StringQt.cpp: (WebCore::String::String):

File:

• trunk/JavaScriptCore/wtf/FastMalloc.cpp (modified) (3 diffs)

trunk/JavaScriptCore/wtf/FastMalloc.cpp

@@ -83 +83 @@
 #include <pthread.h>
 #endif
+#include <wtf/StdLibExtras.h>
 
 #ifndef NO_TCMALLOC_SAMPLES
@@ -1016 +1017 @@
           CRASH();
 
-        *(void**)new_allocation = allocated_regions_;
+        *reinterpret_cast_ptr<void**>(new_allocation) = allocated_regions_;
         allocated_regions_ = new_allocation;
         free_area_ = new_allocation + kAlignedSize;
@@ -2711 +2712 @@
   while ((nptr = ptr + size) <= limit) {
     *tail = ptr;
-    tail = reinterpret_cast<void**>(ptr);
+    tail = reinterpret_cast_ptr<void**>(ptr);
     ptr = nptr;
     num++;