Changeset 64588 in webkit for trunk/JavaScriptCore/runtime/JSArray.h

Timestamp:

Aug 3, 2010, 2:29:32 PM (15 years ago)

Author:

[email protected]

Message:

Change to keep returned pointer from malloc family functions to
quiet memory leak detect. The pointer is saved in the new m_allocBase
member of the ArrayStorage structure. This fixes the issue found in
​https://bugs.webkit.org/show_bug.cgi?id=43229.

Patch by Michael Saboff <​[email protected]> on 2010-08-03
Reviewed by Gavin Barraclough.

As part of this change, we use m_allocBase when reallocating and
freeing the memory associated with ArrayStorage.

• runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):

• runtime/JSArray.h:

File:

• trunk/JavaScriptCore/runtime/JSArray.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSArray.h

@@ -40 +40 @@
         SparseArrayValueMap* m_sparseValueMap;
         void* subclassData; // A JSArray subclass can use this to fill the vector lazily.
+        void* m_allocBase; // Pointer to base address returned by malloc().  Keeping this pointer does eliminate false positives from the leak detector.
         size_t reportedMapCapacity;
 #if CHECK_ARRAY_CONSISTENCY