Changeset 65108 in webkit for trunk/JavaScriptCore/bytecode/CodeBlock.h

Timestamp:

Aug 10, 2010, 6:19:23 PM (15 years ago)

Author:

[email protected]

Message:

Do not post a sync task to the DB thread if it's terminating.
​https://bugs.webkit.org/show_bug.cgi?id=43676

Reviewed by David Levin.

• bindings/generic/ActiveDOMCallback.cpp: The context can

sometimes be NULL. Check if it's NULL instead of asserting that
it's not.
(WebCore::ActiveDOMCallback::ActiveDOMCallback):

• dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):

• storage/Database.cpp: Do not post a sync task to the DB thread

if the DB thread is terminating. Also, when a task is destroyed,
ASSERT that it was completed, or that it had no synchronizer.
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):

• storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTask::~DatabaseTask):
(WebCore::DatabaseTask::performTask):

• storage/DatabaseTask.h:

(WebCore::DatabaseTaskSynchronizer::hasCheckedForTermination):
(WebCore::DatabaseTaskSynchronizer::setHasCheckedForTermination):
(WebCore::DatabaseTask::hasSynchronizer):
(WebCore::DatabaseTask::hasCheckedForTermination):

• storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::terminationRequested):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):

• storage/DatabaseThread.h:

File:

• trunk/JavaScriptCore/bytecode/CodeBlock.h (modified) (1 diff)

trunk/JavaScriptCore/bytecode/CodeBlock.h

@@ -258 +258 @@
         // If we reach this point we've chopped down to one element, no need to check it matches
         ASSERT(size == 1);
-        ASSERT(key == valueAtPosition(&array[0]));
+        //ASSERT(key == valueAtPosition(&array[0]));
         return &array[0];
     }