Changeset 65596 in webkit for trunk/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Aug 18, 2010, 3:02:47 AM (15 years ago)

Author:

[email protected]

Message:

2010-08-18 Gabor Loki <​[email protected]>

Reviewed by Gavin Barraclough.

The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
​https://bugs.webkit.org/show_bug.cgi?id=43897

A 64 bits wide member in a structure is aligned to 8 bytes on ARM by
default, but this is not taken into account in the offset defines of
JITStackFrame.

• jit/JITStubs.cpp:
• jit/JITStubs.h:

File:

• trunk/JavaScriptCore/jit/JITStubs.cpp (modified) (1 diff)

trunk/JavaScriptCore/jit/JITStubs.cpp

@@ -231 +231 @@
 #elif COMPILER(GCC) && CPU(ARM_THUMB2)
 
-#define THUNK_RETURN_ADDRESS_OFFSET      0x3C
-#define PRESERVED_RETURN_ADDRESS_OFFSET  0x40
-#define PRESERVED_R4_OFFSET              0x44
-#define PRESERVED_R5_OFFSET              0x48
-#define PRESERVED_R6_OFFSET              0x4C
-#define REGISTER_FILE_OFFSET             0x50
-#define CALLFRAME_OFFSET                 0x54
-#define EXCEPTION_OFFSET                 0x58
-#define ENABLE_PROFILER_REFERENCE_OFFSET 0x60
+#define THUNK_RETURN_ADDRESS_OFFSET      0x40
+#define PRESERVED_RETURN_ADDRESS_OFFSET  0x44
+#define PRESERVED_R4_OFFSET              0x48
+#define PRESERVED_R5_OFFSET              0x4C
+#define PRESERVED_R6_OFFSET              0x50
+#define REGISTER_FILE_OFFSET             0x54
+#define CALLFRAME_OFFSET                 0x58
+#define EXCEPTION_OFFSET                 0x5C
+#define ENABLE_PROFILER_REFERENCE_OFFSET 0x64
 
 #elif (COMPILER(GCC) || COMPILER(RVCT)) && CPU(ARM_TRADITIONAL)