Changeset 65698 in webkit for trunk/JavaScriptCore/runtime/JSValue.h

Timestamp:

Aug 19, 2010, 2:03:38 PM (15 years ago)

Author:

[email protected]

Message:

2010-08-19 Andreas Kling <​[email protected]>

Reviewed by Geoffrey Garen.

JSC: Move the static_cast into to(U)Int32 fast case
​https://bugs.webkit.org/show_bug.cgi?id=44037

Do the static_cast<(u)int32_t> inline to avoid the function call overhead
for easily converted values (within (u)int32_t range.)

• runtime/JSValue.cpp: (JSC::toInt32SlowCase): (JSC::toUInt32SlowCase):
• runtime/JSValue.h: (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32):

File:

• trunk/JavaScriptCore/runtime/JSValue.h (modified) (4 diffs)

trunk/JavaScriptCore/runtime/JSValue.h

@@ -398 +398 @@
         if (isInt32())
             return asInt32();
+
+        double val = toNumber(exec);
+
+        if (val >= -2147483648.0 && val < 2147483648.0)
+            return static_cast<int32_t>(val);
+
         bool ignored;
-        return toInt32SlowCase(toNumber(exec), ignored);
+        return toInt32SlowCase(val, ignored);
     }
 
@@ -406 +412 @@
         if (isUInt32())
             return asInt32();
+
+        double val = toNumber(exec);
+
+        if (val >= 0.0 && val < 4294967296.0)
+            return static_cast<uint32_t>(val);
+
         bool ignored;
-        return toUInt32SlowCase(toNumber(exec), ignored);
+        return toUInt32SlowCase(val, ignored);
     }
 
@@ -416 +428 @@
             return asInt32();
         }
-        return toInt32SlowCase(toNumber(exec), ok);
+
+        double val = toNumber(exec);
+
+        if (val >= -2147483648.0 && val < 2147483648.0) {
+            ok = true;
+            return static_cast<int32_t>(val);
+        }
+
+        return toInt32SlowCase(val, ok);
     }
 
@@ -425 +445 @@
             return asInt32();
         }
-        return toUInt32SlowCase(toNumber(exec), ok);
+
+        double val = toNumber(exec);
+
+        if (val >= 0.0 && val < 4294967296.0) {
+            ok = true;
+            return static_cast<uint32_t>(val);
+        }
+
+        return toUInt32SlowCase(val, ok);
     }