Changeset 66375 in webkit for trunk/JavaScriptCore/parser/Lexer.h

Timestamp:

Aug 30, 2010, 1:24:40 AM (15 years ago)

Author:

[email protected]

Message:

Refactor number parsing in the lexer
​https://bugs.webkit.org/show_bug.cgi?id=44104

Reviewed by Darin Adler.

Number parsing was full of gotos, and needed a complete
redesign to remove them (Only one remained). Furthermore
integer arithmetic is empolyed for fast cases (= small
integer numbers).

• parser/Lexer.cpp:

(JSC::Lexer::parseHex):
(JSC::Lexer::parseOctal):
(JSC::Lexer::parseDecimal):
(JSC::Lexer::parseNumberAfterDecimalPoint):
(JSC::Lexer::parseNumberAfterExponentIndicator):
(JSC::Lexer::lex):

• parser/Lexer.h:

File:

• trunk/JavaScriptCore/parser/Lexer.h (modified) (1 diff)

trunk/JavaScriptCore/parser/Lexer.h

@@ -97 +97 @@
         ALWAYS_INLINE JSTokenType parseIdentifier(JSTokenData*, LexType);
         ALWAYS_INLINE bool parseString(JSTokenData* lvalp);
+        ALWAYS_INLINE void parseHex(double& returnValue);
+        ALWAYS_INLINE bool parseOctal(double& returnValue);
+        ALWAYS_INLINE bool parseDecimal(double& returnValue);
+        ALWAYS_INLINE void parseNumberAfterDecimalPoint();
+        ALWAYS_INLINE bool parseNumberAfterExponentIndicator();
 
         static const size_t initialReadBufferCapacity = 32;