Changeset 66665 in webkit for trunk/JavaScriptCore/parser/JSParser.cpp

Timestamp:

Sep 2, 2010, 5:57:58 AM (15 years ago)

Author:

[email protected]

Message:

2010-09-02 Alexey Proskuryakov <​[email protected]>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=43230
<rdar://problem/8254215> REGRESSION: Memory leak within JSParser::JSParser

One can't delete a ThreadSpecific object that has data in it. It's not even possible to
enumerate data objects in all threads, much less destroy them from a thread that's destroying
the ThreadSpecific.

• parser/JSParser.cpp: (JSC::JSParser::JSParser):
• runtime/JSGlobalData.h:
• wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
• wtf/WTFThreadData.h: (WTF::WTFThreadData::approximatedStackStart): Moved stack guard tracking from JSGlobalData to WTFThreadData.

• wtf/ThreadSpecific.h: Made destructor unimplemented. It's dangerous, and we probably won't ever face a situation where we'd want to delete a ThreadSpecific object.

File:

• trunk/JavaScriptCore/parser/JSParser.cpp (modified) (2 diffs)

trunk/JavaScriptCore/parser/JSParser.cpp

@@ -34 +34 @@
 #include "ASTBuilder.h"
 #include <wtf/HashFunctions.h>
+#include <wtf/WTFThreadData.h>
 #include <utility>
 
@@ -221 +222 @@
     , m_syntaxAlreadyValidated(provider->isValid())
 {
-    m_endAddress = *(globalData->stackGuards);
-    if (!m_endAddress) {
-        char sample = 0;
-        m_endAddress = &sample - kMaxParserStackUsage;
-        *(globalData->stackGuards) = m_endAddress;
-    }
+    m_endAddress = wtfThreadData().approximatedStackStart() - kMaxParserStackUsage;
     next();
     m_lexer->setLastLineNumber(tokenLine());