Changeset 66665 in webkit for trunk/JavaScriptCore/wtf/WTFThreadData.h

Timestamp:

Sep 2, 2010, 5:57:58 AM (15 years ago)

Author:

[email protected]

Message:

2010-09-02 Alexey Proskuryakov <​[email protected]>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=43230
<rdar://problem/8254215> REGRESSION: Memory leak within JSParser::JSParser

One can't delete a ThreadSpecific object that has data in it. It's not even possible to
enumerate data objects in all threads, much less destroy them from a thread that's destroying
the ThreadSpecific.

• parser/JSParser.cpp: (JSC::JSParser::JSParser):
• runtime/JSGlobalData.h:
• wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
• wtf/WTFThreadData.h: (WTF::WTFThreadData::approximatedStackStart): Moved stack guard tracking from JSGlobalData to WTFThreadData.

• wtf/ThreadSpecific.h: Made destructor unimplemented. It's dangerous, and we probably won't ever face a situation where we'd want to delete a ThreadSpecific object.

File:

• trunk/JavaScriptCore/wtf/WTFThreadData.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/WTFThreadData.h

@@ -113 +113 @@
 #endif
 
+    char* approximatedStackStart() const
+    {
+        return m_approximatedStackStart;
+    }
+
 private:
     AtomicStringTable* m_atomicStringTable;
@@ -129 +134 @@
     friend WTFThreadData& wtfThreadData();
     friend class AtomicStringTable;
+
+    char* m_approximatedStackStart;
 };