Changeset 67894 in webkit for trunk/JavaScriptCore/yarr/RegexJIT.cpp

Timestamp:

Sep 20, 2010, 5:04:22 PM (15 years ago)

Author:

[email protected]

Message:

Fixed detection of alternative smaller than the first alternative
to only check looping alternatives.
​https://bugs.webkit.org/show_bug.cgi?id=46049

Patch by Michael Saboff <​[email protected]> on 2010-09-20
Reviewed by Gavin Barraclough.

• yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

File:

• trunk/JavaScriptCore/yarr/RegexJIT.cpp (modified) (1 diff)

trunk/JavaScriptCore/yarr/RegexJIT.cpp

@@ -1239 +1239 @@
 
         while (state.alternativeValid()) {
-            // Track whether any alternatives are shorter than the first one.
-            hasShorterAlternatives = hasShorterAlternatives || (countCheckedForCurrentAlternative < countToCheckForFirstAlternative);
-
             PatternAlternative* alternative = state.alternative();
             optimizeAlternative(alternative);
 
+            // Track whether any alternatives are shorter than the first one.
+            if (!alternative->onceThrough())
+                hasShorterAlternatives = hasShorterAlternatives || (countCheckedForCurrentAlternative < countToCheckForFirstAlternative);
+            
             for (state.resetTerm(); state.termValid(); state.nextTerm())
                 generateTerm(state);