Changeset 67972 in webkit for trunk/JavaScriptCore/wtf/PassRefPtr.h

Timestamp:

Sep 21, 2010, 11:43:09 AM (15 years ago)

Author:

[email protected]

Message:

2010-09-21 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

<rdar://problem/8363003> REGRESSION: ~1.4% sunspider regression in
interpreter due to 54724 and 54596

Fixed a typo (using "UNLIKELY" instead of "LIKELY").

• wtf/PassRefPtr.h: (WTF::refIfNotNull): (WTF::derefIfNotNull): It is likely that m_ptr != 0 because most RefPtrs hold real data. Also, in cases where they do not hold real data, the compiler usually sees a call to release() right before the call to the destructor, so it can probably optimize out the test completely.

File:

• trunk/JavaScriptCore/wtf/PassRefPtr.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/PassRefPtr.h

@@ -49 +49 @@
     template<typename T> REF_DEREF_INLINE void refIfNotNull(T* ptr)
     {
-        if (UNLIKELY(ptr != 0))
+        if (LIKELY(ptr != 0))
             ptr->ref();
     }
@@ -55 +55 @@
     template<typename T> REF_DEREF_INLINE void derefIfNotNull(T* ptr)
     {
-        if (UNLIKELY(ptr != 0))
+        if (LIKELY(ptr != 0))
             ptr->deref();
     }