Changeset 68207 in webkit for trunk/JavaScriptCore/yarr/RegexJIT.cpp

Timestamp:

Sep 23, 2010, 3:23:19 PM (15 years ago)

Author:

[email protected]

Message:

2010-09-23 Michael Saboff <​[email protected]>

Reviewed by Geoffrey Garen.

Removed extraneous truncation of ovector on entry and error exit.
Changed the initialization to -1 of vector to only initialize
the start indecies, which is sufficient for the pattern/subpatterns.
Changed the JIT code to not clear the end index for subpatterns
as it isn't needed. These changes are worth ~2.7% on v8-regexp.
​https://bugs.webkit.org/show_bug.cgi?id=46404

• runtime/RegExp.cpp: (JSC::RegExp::match):
• yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

File:

• trunk/JavaScriptCore/yarr/RegexJIT.cpp (modified) (1 diff)

trunk/JavaScriptCore/yarr/RegexJIT.cpp

@@ -987 +987 @@
             // A failure WITHIN the parens jumps here
             parenthesesState.linkAlternativeBacktracks(this);
-            if (term.invertOrCapture) {
+            if (term.invertOrCapture)
                 store32(Imm32(-1), Address(output, (term.parentheses.subpatternId << 1) * sizeof(int)));
-                store32(Imm32(-1), Address(output, ((term.parentheses.subpatternId << 1) + 1) * sizeof(int)));
-            }
 
             if (term.quantityType == QuantifierGreedy)