Changeset 68348 in webkit for trunk/JavaScriptCore/runtime/MathObject.cpp

Timestamp:

Sep 26, 2010, 2:38:31 PM (15 years ago)

Author:

[email protected]

Message:

2010-09-26 Mark Hahnenberg <​[email protected]>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
​https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the bug where the arguments to atan2 were being evaluated
out of order.

• runtime/MathObject.cpp: (JSC::mathProtoFuncATan2):

2010-09-26 Mark Hahnenberg <​[email protected]>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
​https://bugs.webkit.org/show_bug.cgi?id=26978

Regression test for the issue where the arguments to atan2 were
evaluated out of order.

• fast/js/math-expected.txt:
• fast/js/script-tests/math.js: (v.valueOf): (w.valueOf):

File:

• trunk/JavaScriptCore/runtime/MathObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/MathObject.cpp

@@ -136 +136 @@
 EncodedJSValue JSC_HOST_CALL mathProtoFuncATan2(ExecState* exec)
 {
-    return JSValue::encode(jsDoubleNumber(exec, atan2(exec->argument(0).toNumber(exec), exec->argument(1).toNumber(exec))));
+    double arg0 = exec->argument(0).toNumber(exec);
+    double arg1 = exec->argument(1).toNumber(exec);
+    return JSValue::encode(jsDoubleNumber(exec, atan2(arg0, arg1)));
 }