Changeset 69773 in webkit for trunk/JavaScriptCore/JavaScriptCore.pri

Timestamp:

Oct 14, 2010, 9:57:00 AM (15 years ago)

Author:

[email protected]

Message:

2010-10-14 No'am Rosenthal <​[email protected]>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
​https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h

• JavaScriptCore.pri:
• wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::mirroredChar): (WTF::Unicode::combiningClass): (WTF::Unicode::direction): (WTF::Unicode::category):

2010-10-14 No'am Rosenthal <​[email protected]>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
​https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.

No new tests, this should be covered by existing tests.

• WebCore.pro:
• platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::currentTextBreakLocaleID):

File:

• trunk/JavaScriptCore/JavaScriptCore.pri (modified) (1 diff)

trunk/JavaScriptCore/JavaScriptCore.pri

@@ -55 +55 @@
 DEFINES += BUILDING_QT__ BUILDING_JavaScriptCore BUILDING_WTF
 
+# CONFIG += text_breaking_with_icu
+
+contains (CONFIG, text_breaking_with_icu) {
+    DEFINES += WTF_USE_QT_ICU_TEXT_BREAKING=1
+}
+
 wince* {
     INCLUDEPATH += $$QT_SOURCE_TREE/src/3rdparty/ce-compat