Changeset 72442 in webkit for trunk/JavaScriptCore/runtime/JSActivation.cpp

Timestamp:

Nov 19, 2010, 2:40:12 PM (15 years ago)

Author:

[email protected]

Message:

2010-11-19 Oliver Hunt <​[email protected]>

Reviewed by Geoffrey Garen.

Don't check for constant registers when we can guarantee that the register won't be in the constant pool
​https://bugs.webkit.org/show_bug.cgi?id=49814

Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR()
when we can guarantee that the register is not referring to a constant.
This makes the interpreter about 0.5% faster, and makes the CallFrame initialisation
logic correct when we're using a faked callframe (as in the case of the globalExec).

• bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
• debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject):
• interpreter/CallFrame.h: (JSC::ExecState::uncheckedR):
• interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute):
• jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
• runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):

File:

• trunk/JavaScriptCore/runtime/JSActivation.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSActivation.cpp

@@ -203 +203 @@
     CallFrame* callFrame = CallFrame::create(activation->d()->registers);
     int argumentsRegister = activation->d()->functionExecutable->generatedBytecode().argumentsRegister();
-    if (!callFrame->r(argumentsRegister).jsValue()) {
+    if (!callFrame->uncheckedR(argumentsRegister).jsValue()) {
         JSValue arguments = JSValue(new (callFrame) Arguments(callFrame));
-        callFrame->r(argumentsRegister) = arguments;
-        callFrame->r(unmodifiedArgumentsRegister(argumentsRegister)) = arguments;
-    }
-
-    ASSERT(callFrame->r(argumentsRegister).jsValue().inherits(&Arguments::info));
-    return callFrame->r(argumentsRegister).jsValue();
+        callFrame->uncheckedR(argumentsRegister) = arguments;
+        callFrame->uncheckedR(unmodifiedArgumentsRegister(argumentsRegister)) = arguments;
+    }
+
+    ASSERT(callFrame->uncheckedR(argumentsRegister).jsValue().inherits(&Arguments::info));
+    return callFrame->uncheckedR(argumentsRegister).jsValue();
 }