Changeset 72842 in webkit for trunk/JavaScriptCore/jsc.cpp

Timestamp:

Nov 29, 2010, 3:35:11 PM (14 years ago)

Author:

[email protected]

Message:

Improved accuracy of command-line SunSpider.

Reviewed by Gavin Barraclough.

JavaScriptCore:

• jsc.cpp:

(functionRun): Changed the "run" function to run a given test in
its own global object. Previously, all tests ran in the same global
object, which created name conflicts, and made globals from previous
tests artificially survive into later tests.

Also changed "run" to return the elapsed milliseconds when running a
given test, for slightly more accurate numbers.

(functionCheckSyntax): Ditto on returning elapsed milliseconds.

SunSpider:

• resources/sunspider-standalone-driver.js: Use the returned number of

elapsed milliseconds from "run" and "checkSyntax" instead of measuring
ourselves, for slightly more accurate numbers.

File:

• trunk/JavaScriptCore/jsc.cpp (modified) (3 diffs)

trunk/JavaScriptCore/jsc.cpp

@@ -209 +209 @@
 EncodedJSValue JSC_HOST_CALL functionRun(ExecState* exec)
 {
-    StopWatch stopWatch;
     UString fileName = exec->argument(0).toString(exec);
     Vector<char> script;
@@ -215 +214 @@
         return JSValue::encode(throwError(exec, createError(exec, "Could not open file.")));
 
-    JSGlobalObject* globalObject = exec->lexicalGlobalObject();
-
+    GlobalObject* globalObject = new (&exec->globalData()) GlobalObject(Vector<UString>());
+
+    StopWatch stopWatch;
     stopWatch.start();
     evaluate(globalObject->globalExec(), globalObject->globalScopeChain(), makeSource(script.data(), fileName));
@@ -246 +246 @@
 
     JSGlobalObject* globalObject = exec->lexicalGlobalObject();
+
+    StopWatch stopWatch;
+    stopWatch.start();
     Completion result = checkSyntax(globalObject->globalExec(), makeSource(script.data(), fileName));
+    stopWatch.stop();
+
     if (result.complType() == Throw)
         throwError(exec, result.value());
-    return JSValue::encode(result.value());
+    return JSValue::encode(jsNumber(stopWatch.getElapsedMS()));
 }