Changeset 74377 in webkit for trunk/JavaScriptCore/parser/Parser.cpp

Timestamp:

Dec 20, 2010, 5:02:31 PM (14 years ago)

Author:

[email protected]

Message:

2010-12-20 Oliver Hunt <​[email protected]>

Reviewed by Geoffrey Garen.

|delete name| in strict mode code should be an early error
​https://bugs.webkit.org/show_bug.cgi?id=50431

Disallow the |delete IDENTIFIER| production in strict mode, and removed
a bunch of now unnecessary code.

• parser/JSParser.cpp: (JSC::JSParser::Scope::collectFreeVariables): (JSC::jsParse): (JSC::JSParser::parseProgram): (JSC::JSParser::parseUnaryExpression):
• parser/JSParser.h:
• parser/Parser.cpp: (JSC::Parser::parse):
• parser/Parser.h: (JSC::Parser::parse):

2010-12-20 Oliver Hunt <​[email protected]>

Reviewed by Geoffrey Garen.

|delete name| in strict mode code should be an early error
​https://bugs.webkit.org/show_bug.cgi?id=50431

Add a test to ensure that |delete IDENTIFIER| is disallowed, even if
IDENTIFIER resolves to a deletable property.

• fast/js/basic-strict-mode-expected.txt:
• fast/js/script-tests/basic-strict-mode.js:

File:

• trunk/JavaScriptCore/parser/Parser.cpp (modified) (2 diffs)

trunk/JavaScriptCore/parser/Parser.cpp

@@ -30 +30 @@
 namespace JSC {
 
-void Parser::parse(JSGlobalObject* lexicalGlobalObject, FunctionParameters* parameters, JSParserStrictness strictness, JSParserMode mode, int* errLine, UString* errMsg)
+void Parser::parse(JSGlobalData* globalData, FunctionParameters* parameters, JSParserStrictness strictness, JSParserMode mode, int* errLine, UString* errMsg)
 {
-    ASSERT(lexicalGlobalObject);
+    ASSERT(globalData);
     m_sourceElements = 0;
 
@@ -46 +46 @@
     *errMsg = UString();
 
-    Lexer& lexer = *lexicalGlobalObject->globalData().lexer;
+    Lexer& lexer = *globalData->lexer;
     lexer.setCode(*m_source, m_arena);
 
-    int parseError = jsParse(lexicalGlobalObject, parameters, strictness, mode, m_source);
+    int parseError = jsParse(globalData, parameters, strictness, mode, m_source);
     int lineNumber = lexer.lineNumber();
     bool lexError = lexer.sawError();