Changeset 75597 in webkit for trunk/Source/JavaScriptCore/yarr/YarrPattern.cpp

Timestamp:

Jan 12, 2011, 3:16:40 AM (14 years ago)

Author:

Csaba Osztrogonác

Message:

Unreviewed, rolling out r75595.
​http://trac.webkit.org/changeset/75595
​https://bugs.webkit.org/show_bug.cgi?id=52286

Patch by Sheriff Bot <​[email protected]> on 2011-01-12
It broke fast/regex/pcre-test-1.html (Requested by Ossy on
#webkit).

• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/RegExp.cpp:
• yarr/Yarr.h: Removed.
• yarr/YarrInterpreter.cpp:
• yarr/YarrInterpreter.h:
• yarr/YarrJIT.cpp:

(JSC::Yarr::jitCompile):

• yarr/YarrJIT.h:

(JSC::Yarr::execute):

• yarr/YarrParser.h:
• yarr/YarrPattern.cpp:

(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

• yarr/YarrPattern.h:

File:

• trunk/Source/JavaScriptCore/yarr/YarrPattern.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/yarr/YarrPattern.cpp

@@ -28 +28 @@
 #include "YarrPattern.h"
 
-#include "Yarr.h"
-#include "YarrParser.h"
+#include "YarrInterpreter.h"
 #include <wtf/Vector.h>
 
@@ -931 +930 @@
 };
 
-const char* YarrPattern::compile(const UString& patternString)
+
+static const char* compile(const UString& patternString, YarrPattern& pattern)
 {
-    YarrPatternConstructor constructor(*this);
+    YarrPatternConstructor constructor(pattern);
 
     if (const char* error = parse(constructor, patternString))
@@ -942 +942 @@
     //      "Note: if the number of left parentheses is less than the number specified
     //       in \#, the \# is taken as an octal escape as described in the next row."
-    if (containsIllegalBackReference()) {
+    if (pattern.containsIllegalBackReference()) {
+        unsigned numSubpatterns = pattern.m_numSubpatterns;
+
         constructor.reset();
 #if !ASSERT_DISABLED
         const char* error =
 #endif
-            parse(constructor, patternString, m_numSubpatterns);
+            parse(constructor, patternString, numSubpatterns);
 
         ASSERT(!error);
+        ASSERT(numSubpatterns == pattern.m_numSubpatterns);
     }
 
@@ -959 +962 @@
 
     return 0;
-}
+};
 
 YarrPattern::YarrPattern(const UString& pattern, bool ignoreCase, bool multiline, const char** error)
@@ -977 +980 @@
     , nonwordcharCached(0)
 {
-    *error = compile(pattern);
+    *error = compile(pattern, *this);
 }