Changeset 76078 in webkit for trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

Timestamp:

Jan 18, 2011, 3:45:34 PM (15 years ago)

Author:

[email protected]

Message:

2011-01-18 Geoffrey Garen <​[email protected]>

Reviewed by Darin Adler.

Removed RegisterFile::markGlobals because it was obtuse, and it
unnecessarily relied on conservative marking.
​https://bugs.webkit.org/show_bug.cgi?id=52668

• interpreter/RegisterFile.h: Removed markGlobals.

• runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): Added a comment explaning why some JSActivations don't always mark their registers arrays.

• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark the registers array directly.

File:

• trunk/Source/JavaScriptCore/runtime/JSActivation.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

@@ -54 +54 @@
     Base::markChildren(markStack);
 
+    // No need to mark our registers if they're still in the RegisterFile.
     Register* registerArray = d()->registerArray.get();
     if (!registerArray)