Changeset 76454 in webkit for trunk/Source/JavaScriptCore/runtime/MarkStack.h

Timestamp:

Jan 22, 2011, 12:11:22 PM (14 years ago)

Author:

[email protected]

Message:

2011-01-22 Geoffrey Garen <​[email protected]>

Reviewed by Geoffrey Garen.

Rubber-stamped by Maciej Stachowiak.

A few of Maciej's review suggestions for my last patch.
​https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

• Android.mk:
• CMakeLists.txt:
• GNUmakefile.am:
• JavaScriptCore.gypi:
• JavaScriptCore.pro:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems.

• runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add):
• runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer.

• runtime/Heap.cpp: (JSC::Heap::markRoots):
• runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively):
• runtime/MachineStackMarker.h:
• runtime/MarkStack.h: Updated for changes above.

File:

• trunk/Source/JavaScriptCore/runtime/MarkStack.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/MarkStack.h

@@ -189 +189 @@
     };
     
-    class ConservativeSet {
-    public:
-        void add(JSCell* cell) { m_vector.append(cell); }
-        void mark(MarkStack& markStack)
-        {
-            for (size_t i = 0; i < m_vector.size(); ++i)
-                markStack.append(m_vector[i]);
-        }
-
-    private:
-        Vector<JSCell*, 64> m_vector;
-    };
 }