Changeset 76611 in webkit for trunk/Source/JavaScriptCore/JavaScriptCore.pro

Timestamp:

Jan 25, 2011, 10:44:11 AM (14 years ago)

Author:

Antti Koivisto

Message:

REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
​https://bugs.webkit.org/show_bug.cgi?id=53061

Reviewed by Oliver Hunt.

Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.

• CMakeLists.txt:
• GNUmakefile.am:
• JavaScriptCore.exp:
• JavaScriptCore.gypi:
• JavaScriptCore.pro:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• parser/JSParser.cpp:

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

• parser/SourceProvider.h:
• parser/SourceProviderCache.cpp: Added.

(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):

• parser/SourceProviderCache.h: Added.

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):

• parser/SourceProviderCacheItem.h: Added.

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):

File:

• trunk/Source/JavaScriptCore/JavaScriptCore.pro (modified) (1 diff)

trunk/Source/JavaScriptCore/JavaScriptCore.pro

@@ -116 +116 @@
     parser/ParserArena.cpp \
     parser/Parser.cpp \
+    parser/SourceProviderCache.cpp \
     profiler/Profile.cpp \
     profiler/ProfileGenerator.cpp \