Ignore:
Timestamp:
Feb 1, 2011, 6:40:03 AM (15 years ago)
Author:
[email protected]
Message:

2011-02-01 Dave Tapuska <​[email protected]>

Reviewed by Gavin Barraclough.

MacroAssemblerARM would generate code that did 32bit loads
on addresses that were not aligned. More specifically it would
generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
The intended instruction really is ldrb r8,[r1, #7]; ensure we
call load8 instead of load32.

​https://bugs.webkit.org/show_bug.cgi?id=46095

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8):
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r77242 r77248  
     12011-02-01  Dave Tapuska  <[email protected]>
     2
     3        Reviewed by Gavin Barraclough.
     4
     5        MacroAssemblerARM would generate code that did 32bit loads
     6        on addresses that were not aligned. More specifically it would
     7        generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
     8        The intended instruction really is ldrb r8,[r1, #7]; ensure we
     9        call load8 instead of load32.
     10
     11        https://bugs.webkit.org/show_bug.cgi?id=46095
     12
     13        * assembler/MacroAssemblerARM.h:
     14        (JSC::MacroAssemblerARM::set32Test32):
     15        (JSC::MacroAssemblerARM::set32Test8):
     16
    1172011-02-01  Darin Fisher  <[email protected]>
    218
Note: See TracChangeset for help on using the changeset viewer.