Changeset 77360 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

Timestamp:

Feb 1, 2011, 9:05:55 PM (14 years ago)

Author:

[email protected]

Message:

2011-02-01 Sheriff Bot <​[email protected]>

Unreviewed, rolling out r77297.
​http://trac.webkit.org/changeset/77297
​https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
• wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
• wtf/unicode/UTF8.h:

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

@@ -250 +250 @@
 
         DeprecatedPtr<JSGlobalObject> m_globalObject;
+        Heap* m_heap;
 
     public:
@@ -617 +618 @@
             : CodeBlock(ownerExecutable, codeType, globalObject, sourceProvider, sourceOffset, &m_unsharedSymbolTable, false)
         {
-            m_globalObject->codeBlocks().add(this);
+            m_heap->codeBlocks().add(this);
         }
 
         ~GlobalCodeBlock()
         {
-            if (m_globalObject)
-                m_globalObject->codeBlocks().remove(this);
-        }
-
-        void clearGlobalObject() { m_globalObject = 0; }
+            m_heap->codeBlocks().remove(this);
+        }
 
     private: