Ignore:
Timestamp:
Feb 13, 2011, 2:12:10 AM (14 years ago)
Author:
[email protected]
Message:

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
​https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

  • API/JSCallbackObject.h: Remove pointlessly overloaded method.
  • API/JSCallbackObjectFunctions.h: Ditto.
  • runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

  • runtime/Arguments.h: Ditto.

JavaScriptGlue:

  • UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

  • UserObjectImp.h:
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/API/JSCallbackObjectFunctions.h

    r77151 r78428  
    165165
    166166template <class Base>
    167 bool JSCallbackObject<Base>::getOwnPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
    168 {
    169     return getOwnPropertySlot(exec, Identifier::from(exec, propertyName), slot);
    170 }
    171 
    172 template <class Base>
    173167bool JSCallbackObject<Base>::getOwnPropertyDescriptor(ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor)
    174168{
Note: See TracChangeset for help on using the changeset viewer.