Changeset 78428 in webkit for trunk/Source/JavaScriptCore/runtime/Arguments.cpp

Timestamp:

Feb 13, 2011, 2:12:10 AM (14 years ago)

Author:

[email protected]

Message:

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
​https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

• API/JSCallbackObject.h: Remove pointlessly overloaded method.
• API/JSCallbackObjectFunctions.h: Ditto.
• runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

• runtime/Arguments.h: Ditto.

JavaScriptGlue:

• UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

• UserObjectImp.h:

File:

• trunk/Source/JavaScriptCore/runtime/Arguments.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/Arguments.cpp

@@ -254 +254 @@
 }
 
-void Arguments::put(ExecState* exec, unsigned i, JSValue value, PutPropertySlot& slot)
+void Arguments::put(ExecState* exec, unsigned i, JSValue value)
 {
     if (i < d->numArguments && (!d->deletedArguments || !d->deletedArguments[i])) {
@@ -264 +264 @@
     }
 
+    PutPropertySlot slot;
     JSObject::put(exec, Identifier(exec, UString::number(i)), value, slot);
 }