Changeset 78428 in webkit for trunk/Source/JavaScriptCore/runtime/Arguments.h

Timestamp:

Feb 13, 2011, 2:12:10 AM (14 years ago)

Author:

[email protected]

Message:

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
​https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

• API/JSCallbackObject.h: Remove pointlessly overloaded method.
• API/JSCallbackObjectFunctions.h: Ditto.
• runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

• runtime/Arguments.h: Ditto.

JavaScriptGlue:

• UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

• UserObjectImp.h:

File:

• trunk/Source/JavaScriptCore/runtime/Arguments.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Arguments.h

@@ -108 +108 @@
         virtual void getOwnPropertyNames(ExecState*, PropertyNameArray&, EnumerationMode mode = ExcludeDontEnumProperties);
         virtual void put(ExecState*, const Identifier& propertyName, JSValue, PutPropertySlot&);
-        virtual void put(ExecState*, unsigned propertyName, JSValue, PutPropertySlot&);
+        virtual void put(ExecState*, unsigned propertyName, JSValue);
         virtual bool deleteProperty(ExecState*, const Identifier& propertyName);
         virtual bool deleteProperty(ExecState*, unsigned propertyName);