Changeset 78945 in webkit for trunk/Source/JavaScriptCore/runtime/JSArray.cpp

Timestamp:

Feb 17, 2011, 8:29:16 PM (14 years ago)

Author:

[email protected]

Message:

2011-02-17 Sheriff Bot <​[email protected]>

Unreviewed, rolling out r78856 and r78907.
​http://trac.webkit.org/changeset/78856
​http://trac.webkit.org/changeset/78907
​https://bugs.webkit.org/show_bug.cgi?id=54705

These seem to break tests on 32-bit builds. (Requested by
aroben on #webkit).

• JavaScriptCore.xcodeproj/project.pbxproj:
• collector/handles/Global.h: (JSC::Global::internalSet):
• collector/handles/Handle.h: (JSC::HandleTypes::getFromSlot): (JSC::HandleTypes::toJSValue): (JSC::HandleTypes::validateUpcast): (JSC::HandleConverter::operator->): (JSC::HandleConverter::operator*): (JSC::Handle::Handle): (JSC::Handle::get):
• runtime/JSArray.cpp: (JSC::JSArray::sortNumeric):
• runtime/JSObject.h: (JSC::JSObject::inlineGetOwnPropertySlot):
• runtime/SlotAccessor.h: Removed.
• runtime/WeakGCPtr.h: (JSC::WeakGCPtr::get): (JSC::WeakGCPtr::internalSet):
• runtime/WriteBarrier.h: (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::clear): (JSC::WriteBarrierBase::slot): (JSC::WriteBarrierBase::operator UnspecifiedBoolType*): (JSC::WriteBarrierBase::operator!): (JSC::WriteBarrierBase::setWithoutWriteBarrier): (JSC::WriteBarrier::WriteBarrier):

File:

• trunk/Source/JavaScriptCore/runtime/JSArray.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSArray.cpp

@@ -899 +899 @@
     size_t size = storage->m_numValuesInVector;
     for (size_t i = 0; i < size; ++i) {
-        if (!storage->m_vector[i]->isNumber()) {
+        if (!storage->m_vector[i].isNumber()) {
             allValuesAreNumbers = false;
             break;