Changeset 81051 in webkit for trunk/Source/JavaScriptCore/API/JSClassRef.cpp

Timestamp:

Mar 14, 2011, 1:40:49 PM (14 years ago)

Author:

[email protected]

Message:

<​http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

• API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

• DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions): Remove duplicate entries.

File:

• trunk/Source/JavaScriptCore/API/JSClassRef.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSClassRef.cpp

@@ -85 +85 @@
                 StaticValueEntry* entry = new StaticValueEntry(staticValue->getProperty, staticValue->setProperty, staticValue->attributes);
                 StringImpl* impl = valueName.impl();
-                impl->ref();
-                m_staticValues->add(impl, entry);
+                StaticValueEntry* existingEntry = m_staticValues->get(impl);
+                m_staticValues->set(impl, entry);
+                delete existingEntry;
             }
             ++staticValue;
@@ -100 +101 @@
                 StaticFunctionEntry* entry = new StaticFunctionEntry(staticFunction->callAsFunction, staticFunction->attributes);
                 StringImpl* impl = functionName.impl();
-                impl->ref();
-                m_staticFunctions->add(impl, entry);
+                StaticFunctionEntry* existingEntry = m_staticFunctions->get(impl);
+                m_staticFunctions->set(impl, entry);
+                delete existingEntry;
             }
             ++staticFunction;