Changeset 8158 in webkit for trunk/JavaScriptCore/kjs/value.cpp

Timestamp:

Dec 8, 2004, 2:54:45 PM (20 years ago)

Author:

mjs

Message:

Reviewed by Darin.

<rdar://problem/3908017> REGRESSION (172-173): assertion in ObjectImp::construct trying to create JS error (24hourfitness.com)

The fix was to implement copy constructor and assignment operator,
the ones that worked on the base class did not replace the
defaults apparently!

• kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::operator=):

Also fixed a bug in the GC test mode that compares the results of
the old collector and the new collector.

• kjs/value.cpp: (ValueImp::mark):

File:

• trunk/JavaScriptCore/kjs/value.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/value.cpp

@@ -77 +77 @@
     _flags |= VI_CONSERVATIVE_MARKED;
   } else {
-    if (!(_flags | VI_CONSERVATIVE_MARKED)) {
-      printf("Conservative collector missed ValueImp 0x%x.\n", (int)this);
+    if (!(_flags & VI_CONSERVATIVE_MARKED)) {
+      printf("Conservative collector missed ValueImp 0x%x. refcount %d, protect count %d\n", (int)this, refcount, ProtectedValues::getProtectCount(this));
     }
     _flags |= VI_MARKED;