Ignore:
Timestamp:
Apr 21, 2011, 4:08:15 PM (14 years ago)
Author:
[email protected]
Message:

2011-04-21 Oliver Hunt <[email protected]>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::visitChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren): (JSC::JSCallbackObject::visitChildren):
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures): (JSC::EvalCodeCache::visitAggregate): (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h:
  • bytecode/EvalCodeCache.h:
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::visitAggregate):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::visitAggregate):
  • bytecode/StructureStubInfo.h:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • debugger/DebuggerActivation.h:
  • heap/HandleHeap.cpp: (JSC::WeakHandleOwner::isReachableFromOpaqueRoots): (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles):
  • heap/HandleHeap.h:
  • heap/HandleStack.cpp: (JSC::HandleStack::mark):
  • heap/HandleStack.h:
  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • heap/Heap.h:
  • heap/MarkStack.cpp: (JSC::MarkStack::visitChildren): (JSC::MarkStack::drain):
  • heap/MarkStack.h: (JSC::HeapRootVisitor::HeapRootVisitor): (JSC::HeapRootVisitor::mark): (JSC::HeapRootVisitor::visitor):
  • heap/MarkedSpace.h:
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/ArgList.h:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Arguments.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSArray.h: (JSC::JSArray::visitDirect):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::visitChildren):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp: (JSC::visitIfNeeded): (JSC::JSGlobalObject::visitChildren):
  • runtime/JSGlobalObject.h:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSObject.h: (JSC::JSObject::visitDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::overridesVisitChildren):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/JSWrapperObject.h:
  • runtime/JSZombie.h: (JSC::JSZombie::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/NativeErrorConstructor.h:
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h:
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::visitChildren):
  • runtime/SmallStrings.h:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::visitChildren):
  • runtime/Structure.h:
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::createStructure):

2011-04-21 Oliver Hunt <[email protected]>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • UserObjectImp.cpp: (UserObjectImp::visitChildren):

2011-04-21 Oliver Hunt <[email protected]>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSDOMBinding.cpp: (WebCore::visitActiveObjectsForContext): (WebCore::markDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementation::visitChildren):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::visitChildren):
  • bindings/js/JSHTMLLinkElementCustom.cpp: (WebCore::JSHTMLLinkElement::visitChildren):
  • bindings/js/JSHTMLStyleElementCustom.cpp: (WebCore::JSHTMLStyleElement::visitChildren):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots): (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeCustom.h:
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
  • bindings/js/JSProcessingInstructionCustom.cpp: (WebCore::JSProcessingInstruction::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWebKitAnimationListCustom.cpp: (WebCore::JSWebKitAnimationList::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObject::visitChildren): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
  • bridge/qt/qt_runtime.h:
  • dom/EventListener.h: (WebCore::EventListener::visitJSFunction):
  • dom/EventTarget.h: (WebCore::EventTarget::visitJSEventListeners):
  • dom/Node.h:
  • dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::visitAggregate):
  • page/DOMWindow.h:
  • workers/WorkerContext.h:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/runtime/JSFunction.h

    r84052 r84556  
    8585
    8686    protected:
    87         const static unsigned StructureFlags = OverridesGetOwnPropertySlot | ImplementsHasInstance | OverridesMarkChildren | OverridesGetPropertyNames | JSObject::StructureFlags;
     87        const static unsigned StructureFlags = OverridesGetOwnPropertySlot | ImplementsHasInstance | OverridesVisitChildren | OverridesGetPropertyNames | JSObject::StructureFlags;
    8888
    8989    private:
     
    9898        virtual bool deleteProperty(ExecState*, const Identifier& propertyName);
    9999
    100         virtual void markChildren(MarkStack&);
     100        virtual void visitChildren(SlotVisitor&);
    101101
    102102        static JSValue argumentsGetter(ExecState*, JSValue, const Identifier&);
Note: See TracChangeset for help on using the changeset viewer.