Changeset 88974 in webkit for trunk/Source/JavaScriptCore/parser/Lexer.h

Timestamp:

Jun 15, 2011, 2:46:13 PM (14 years ago)

Author:

[email protected]

Message:

2011-06-15 Oliver Hunt <​[email protected]>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
​https://bugs.webkit.org/show_bug.cgi?id=62720

Add test for the "interesting" ascii characters that may occur in an identifier

• fast/js/parser-syntax-check-expected.txt:
• fast/js/script-tests/parser-syntax-check.js:

2011-06-15 Oliver Hunt <​[email protected]>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
​https://bugs.webkit.org/show_bug.cgi?id=62720

Problem here is that the lexer wasn't considering '$' to be
a valid character in an identifier.

• parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):

File:

• trunk/Source/JavaScriptCore/parser/Lexer.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Lexer.h

@@ -203 +203 @@
         // Here's the shift
         if (ptr < end) {
-            if (!WTF::isASCII(*ptr) || (*ptr == '\\') || (*ptr == '_'))
+            if ((!WTF::isASCII(*ptr)) || (*ptr == '\\') || (*ptr == '_') || (*ptr == '$'))
                 goto slowCase;
             m_current = *ptr;